- Issue created by @borwickja
- 🇺🇸United States grasmash
I'd consider this a bug -- there should be a clear error message. But, you can resolve this by creating a key as per the instruction on the project page:
Signing and/or validating JWTs requires a secret. The JWT module leverages the key module to manage these secrets. Once everything is installed, you will need to create a new key at Manage > Configuration > System > Keys (admin/config/system/keys). Add a new or existing key there.
and
Once you have created a key, navigate to Configuration > System > JWT Authentication (admin/config/system/jwt). Choose the key that you just created in the previous step.
- 🇮🇳India abhishek_virasat
abhishek_gupta1 → made their first commit to this issue’s fork.
- Merge request !4fix the issue Getting this error even if key is set → (Open) created by abhishek_virasat
- last update
about 1 year ago 12 pass - Status changed to Needs review
about 1 year ago 9:51am 12 January 2024 - 🇮🇳India abhishek_virasat
@borwickja, i have fixed the issue and created MR. please kindly review the MR
- Status changed to Needs work
about 1 year ago 8:08pm 29 January 2024 - 🇺🇸United States pwolanin
The logic change looks ok, but you changed the code style to be incorrect:
12 coding standards messages ✗ 12 more than branch result src/Transcoder/JwtTranscoder.php ✗ 12 more line 261 Line indented incorrectly; expected 6 spaces, found 8 262 Expected newline after closing brace 263 Line indented incorrectly; expected 6 spaces, found 8 264 Line indented incorrectly; expected 8 spaces, found 12 265 Line indented incorrectly; expected 6 spaces, found 8 265 Expected newline after closing brace 266 Line indented incorrectly; expected 8 spaces, found 12 267 Line indented incorrectly; expected 6 spaces, found 8 271 Line indented incorrectly; expected 2 spaces, found 0 271 Closing brace indented incorrectly; expected 2 spaces, found 0 271 Expected 1 blank line after function; 2 found 274 The closing brace for the class must have an empty line before it - 🇩🇪Germany broon Potsdam
Apart from the coding style issues, this MR resolves the problems for me when running PHPUnit tests on custom modules (requiring JWT functionality).
- First commit to issue fork.
- 🇩🇪Germany donquixote
Rebase and code cleanup.
I still have some concerns with the branch, which I will address later.I am attaching a patch for people to apply in their composer.json.
- Merge request !21Issue #3409096: Initialize JwtTranscoder->algorithmType with NULL. → (Open) created by donquixote
- 🇩🇪Germany donquixote
I have a simpler approach.
I did not see how to rename the MR, and also I don't want to destroy others' work.
So I created a new branch with new MR.Note that this issue only covers a part of the problem.
There are still other scenarios when JwtTranscoder is not fully initialized, and we are sending NULL values or accessing uninitialized property:- The JwtTranscoder->algorithm should also be initialized with NULL, because it can be accessed before it is initialized.
- In JwtTranscoder->encode(), we need to check if $key is NULL.For now I consider these problems as out of scope for this issue.
- 🇩🇪Germany donquixote
I suspect none of the fails (phpstan, phpunit, phpcs) are caused by this MR.