Warning when visiting settings form

Created on 15 December 2023, 6 months ago

Updated 7 March 2024, 4 months ago

Problem/Motivation

If you have no page headers to modify then there is the following warning displayed:
Warning: foreach() argument must be of type array|object, null given in Drupal\access_unpublished\Form\SettingsForm->prepareHeadersDisplay()

Proposed resolution

Cast $headers as array to ensure warning is not shown.

🐛 Bug report

Status

Needs review

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom kristiantosney

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @kristiantosney
Comment 6 months ago →
🇬🇧United Kingdom kristiantosney
Comment 6 months ago →
🇬🇧United Kingdom kristiantosney
Status changed to Needs review 4 months ago11:24am 7 March 2024
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
last update 4 months ago
10 pass, 2 fail
Comment 4 months ago →
🇺🇸United States DamienMcKenna NH, USA
Thank you for opening the issue and providing a patch.

Does this work? It skips the foreach() loop if the $headers list is empty.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024