- Issue created by @heyyo
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 9:42am 15 December 2023 - 🇮🇳India viren18febS
I have resolved the issue & added patch, please review.
- Status changed to Needs work
about 1 year ago 8:44am 21 December 2023 - 🇺🇦Ukraine quadrexdev Lutsk
Thanks, that sounds reasonable.
Just two points to finish this issue:
1. Please create a merge request using forks.
2. Let's combine if checks within one statement:Before:
if(!empty($form[$entity_type_id])){ if (empty(Element::children($form[$entity_type_id]))) { unset($form[$entity_type_id]); }
After:
if(!empty($form[$entity_type_id]) && empty(Element::children($form[$entity_type_id]))) { unset($form[$entity_type_id]); }
- Status changed to Needs review
about 1 year ago 9:05am 21 December 2023 - 🇮🇳India viren18febS
@quadrexdev, I have update the above solution & generated the MR, please review.
- Status changed to Fixed
11 months ago 10:49am 8 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.