Error if no entity types are selected

Message TypeError: Drupal\Core\Render\Element::children(): Argument #1 ($elements) must be of type array, null given, called in /var/www/html/web/modules/contrib/flexible_descriptions/src/Form/FlexibleDescriptionsManagementForm.php on line 166 in Drupal\Core\Render\Element::children() (line 72 of /var/www/html/web/core/lib/Drupal/Core/Render/Element.php).

Comments & Activities

Issue created by @heyyo
First commit to issue fork.
Status changed to Needs review 7 months ago9:42am 15 December 2023
Comment 7 months ago →
🇮🇳India viren18febS
I have resolved the issue & added patch, please review.
Status changed to Needs work 6 months ago8:44am 21 December 2023

Comment 6 months ago →

🇺🇦Ukraine quadrexdev Lutsk

Thanks, that sounds reasonable.

Just two points to finish this issue:

1. Please create a merge request using forks.
2. Let's combine if checks within one statement:

Before:

 if(!empty($form[$entity_type_id])){
                 if (empty(Element::children($form[$entity_type_id]))) {
                     unset($form[$entity_type_id]);
             }

After:

 if(!empty($form[$entity_type_id]) && empty(Element::children($form[$entity_type_id]))) {
                   unset($form[$entity_type_id]);
             }

Merge request !14issue-3408782-error-if-no-fixes. → (Merged) created by viren18febS
Status changed to Needs review 6 months ago9:05am 21 December 2023
Comment 6 months ago →
🇮🇳India viren18febS
@quadrexdev, I have update the above solution & generated the MR, please review.
Status changed to Fixed 5 months ago10:49am 8 February 2024
Comment 5 months ago →
🇺🇦Ukraine quadrexdev Lutsk
Merged, thanks!
Comment 4 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Error if no entity types are selected

Merge Requests

!14Error if no entity types are selected
Merged

Comments & Activities

Error if no entity types are selected

Merge Requests

!14Error if no entity types are selected Merged

Comments & Activities

!14Error if no entity types are selected
Merged