- Issue created by @chaimaa faris
- ๐ฎ๐ณIndia chetan 11
chetan 11 โ made their first commit to this issueโs fork.
- Issue was unassigned.
- Status changed to Needs review
11 months ago 9:52am 13 December 2023 - ๐ฎ๐ณIndia chetan 11
Hi,
I have fixed the above error on "views_autocomplete_api" module, please check the attached MR.
Thanks. Hi Chetan,
Unfortunately, your commit removed the fix :/
if (count($display_id) !== count($count_view)) {
This should be replaced by
if (count($display_id) !== $count_view) {
We are already have count in the Controller which call the Service
# src/Controller/ViewsAutocompleteApiController.php $display_ids = $this->viewsAutocompleteManager->getViewsDisplayId($display_id, count($view_name)); # /Service/ViewsAutocompleteApiManager.php public function getViewsDisplayId($display_id, $count_view) { if (!empty($display_id)) { $display_id = explode(',', $display_id); if (count($display_id) !== count($count_view)) {
- ๐ฟ๐ผZimbabwe chaimaa faris
I fixed the problem mentioned in the issue. You can use this patch if you encounter the same problem