- Issue created by @danielspeicher
- Merge request !11Issue #3408174 by danielspeicher: Register event before execution → (Closed) created by danielspeicher
- 🇩🇪Germany jurgenhaas Gottmadingen
Everything related to
onBeforeInitialExceution
has been deliberately removed and we don't want to bring that back. It should then be the other way round, that we see how we can move the after event to the other location as well. - 🇩🇪Germany danielspeicher Steisslingen
Ok. Where shall we create the tokens? Now our entire solution is broken.
- 🇩🇪Germany jurgenhaas Gottmadingen
Here is the draft change record which links to all the relevant ECA issues that have been implemented to bring all event related tasks into the ECA event plugins: https://www.drupal.org/node/3381190 → (draft CRs are available from https://www.drupal.org/list-changes/eca/drafts → )
So, we moved token data provider functionality into the event plugin already, and we probably also have to move the cleanup there as well.
- 🇩🇪Germany jurgenhaas Gottmadingen
@danielspeicher the token preparation went into the ECA event plugin, as mentioned before. I just forgot to remove that redundant method in the subscriber, which I've now done in the issue fork.
The token preparation is now available at
\Drupal\eca_push_framework\Plugin\ECA\Event\ChannelEvent::buildEventData
Is that not working? If so, can you prepare a test case where I could debug why?
-
danielspeicher →
committed 9fb65d15 on 2.3.x
Resolve #3408174 "Register event before"
-
danielspeicher →
committed 9fb65d15 on 2.3.x
- Status changed to Fixed
about 1 year ago 2:43pm 13 December 2023 - 🇩🇪Germany danielspeicher Steisslingen
Now, codebase is correct. I test, if all is working now. If not a new issue will be created.
-
jurgenhaas →
committed d1eae00b on 2.3.x
Issue #3408174 by danielspeicher: Register event before execution
-
jurgenhaas →
committed d1eae00b on 2.3.x
-
danielspeicher →
committed d9e13c01 on 2.3.x
Issue #3408174 by danielspeicher: Register event before execution
-
danielspeicher →
committed d9e13c01 on 2.3.x
-
danielspeicher →
committed ccbea838 on 2.3.x
Issue #3408174 by danielspeicher: Register event before execution
-
danielspeicher →
committed ccbea838 on 2.3.x
Automatically closed - issue fixed for 2 weeks with no activity.