Error when embedding non-existing Media in WYSIWYG editor

Thank you @sandzel for the patch!

This is working for us:
- Drupal 10.1.6
- Acquia DAM Version: 1.0.11
- 8.1.18

RTBC +1

@sandzel it looks like you're done working on this? Moving to needs review.

Now tested, cannot reproduce on the latest development branch 1.1.x. After saving the content entity with the WYSIWYG field it gets properly redirected to its canonical page where the embedded asset is being displayed while the invalid UUID is represented with a generic placeholder reading “The referenced media source is missing and needs to be re-embedded”:



This message originates from core's MediaEmbed filter plugin which is responsible for processing these <drupal-media …></drupal-media> custom HTML tags you also included as a sample. Interestingly according to Git blame, this entire class hasn't changed for 4 years, so the same protection mechanism should be in place for 10.1.6 which core version @scott_earnest confirmed. Also tested with both enabled and disabled on-site storing of asset files (a feature added in 1.1.x) but still worked as expected.

Apparently we need a more detailed list of reproduction steps to get closer to the circumstances the reporter had.

Due to the fact that we call \Drupal\Core\Entity\EntityStorageBase::loadByProperties() which always returns an array both on its positive and negative branches of logic (source code) I see checking is_array() somewhat pointless. So I support @sandzel's idea to rather check empty() instead.

Also backported to 1.0.x

Automatically closed - issue fixed for 2 weeks with no activity.