Need to change twitter logo to 'X'.

Created on 8 December 2023, about 1 year ago
Updated 15 July 2024, 5 months ago

🐛 Bug report
Status

RTBC

Version

2.0

Component

Code

Created by

🇮🇳India alok_singh

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @alok_singh
  • Status changed to Needs review about 1 year ago
  • Status changed to RTBC about 1 year ago
  • Verified MR7 on 9.5.x, the Twitter icon is updated. Added screenshots for reference, RTBC++

  • Status changed to Needs review 10 months ago
  • 🇮🇳India hamid.ali

    @alok_singh @tanuja since we can't add the logo directly as an SVG to maintain consistency. Since we are using the Font Awesome library we need to update the Twitter logo using that only. I am attaching the patch along with the screenshot.

    After Patch:

  • 🇮🇳India alok_singh

    @hamidali, For single icon we don't use cdn link because of this will cause loading issue in the site.
    Please learn more, then implement.
    And try to create MR not a patch.

  • 🇮🇳India hamid.ali

    @alok_singh adding svg image directly is not following the coding standards since all the icons are added using font awesome. Thats why I pointed the same. Kindly go through the code once and check the coding standards no icon has been added directly as a svg within the markup.

  • Status changed to RTBC 5 months ago
  • 🇮🇳India riddhi.addweb

    The mentioned issue is resolved, & I have also checked it in the Simplytestme sandbox and it is working as expected. I am attaching the Screenshots & doing RTBC for the same.

Production build 0.71.5 2024