- Issue created by @alok_singh
- Merge request !7ebook_zymphonies_theme-3406950: Need to change twitter logo to 'X'. → (Open) created by alok_singh
- Status changed to Needs review
10 months ago 5:33am 8 December 2023 - Status changed to RTBC
9 months ago 9:00am 22 December 2023 Verified MR7 on 9.5.x, the Twitter icon is updated. Added screenshots for reference, RTBC++
- Status changed to Needs review
8 months ago 7:12am 14 February 2024 - 🇮🇳India hamid.ali
@alok_singh @tanuja since we can't add the logo directly as an SVG to maintain consistency. Since we are using the Font Awesome library we need to update the Twitter logo using that only. I am attaching the patch along with the screenshot.
After Patch:
- 🇮🇳India alok_singh
@hamidali, For single icon we don't use cdn link because of this will cause loading issue in the site.
Please learn more, then implement.
And try to create MR not a patch. - 🇮🇳India hamid.ali
@alok_singh adding svg image directly is not following the coding standards since all the icons are added using font awesome. Thats why I pointed the same. Kindly go through the code once and check the coding standards no icon has been added directly as a svg within the markup.
- Status changed to RTBC
3 months ago 10:28am 15 July 2024 - 🇮🇳India riddhi.addweb
The mentioned issue is resolved, & I have also checked it in the Simplytestme sandbox and it is working as expected. I am attaching the Screenshots & doing RTBC for the same.