Support for the Mercury Editor module

Created on 7 December 2023, almost 2 years ago

Problem/Motivation

When setting Gin as the admin theme for the Mercury Editor β†’ , the published option isn't rendered. By default every time you save a node in the Mercury Editor edit mode, it unpublishes the node. I've tried loading Claro as the admin theme and the publish check box is there. I assume this is because Gin moves the action buttons somewhere else.

Steps to reproduce

Install mercury editor and the gin admin theme. Enable mercury editor for the content type and edit a node. There is no published option.

Before:

After:

✨ Feature request
Status

Active

Component

User interface

Created by

πŸ‡ΊπŸ‡ΈUnited States jsheffers

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @jsheffers
  • Status changed to Closed: won't fix almost 2 years ago
  • πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

    You might want to instead open an issue in the Mercury editor issue queue so that the devs from the Mercury editor can look into why it's not properly working and fixing it on their end as we're just extending Core defaults.

    So I'm closing this.

  • πŸ‡ΊπŸ‡ΈUnited States bjcooper Nebraska, USA

    This happens because the published checkbox gets moves to the sticky action buttons in Gin, which isn't rendered in the Mercury Editor context. So there's no way to publish content that way.

    I think the solution would indeed be for Mercury Editor to use hook_gin_ignore_sticky_form_actions_alter() to skip moving the published checkbox to sticky action buttons (which aren't rendered) in the mercury editor context. However, there is a Gin issue where the results of that hook are ignored for content forms and cannot be disabled. I think that's a Gin issue, which would give Mercury Editor a legit way to implement a solution. Here's a related Gin issue: https://www.drupal.org/project/gin/issues/3488050 πŸ› Uncaught TypeError: formActions is null on a form that is trying not to use Gin form modifications Active

  • πŸ‡ΊπŸ‡ΈUnited States bjcooper Nebraska, USA
  • πŸ‡ΊπŸ‡ΈUnited States bjcooper Nebraska, USA
  • Pipeline finished with Success
    5 months ago
    Total: 210s
    #499129
  • Status changed to Needs review about 1 month ago
  • πŸ‡ͺπŸ‡ΈSpain paucala

    We also have this issue, the workarround for us has been set the theme as Claro on the ME settings, but it would be great that it worked with Gin

Production build 0.71.5 2024