- Issue created by @lexfunk
- πΊπΈUnited States lexfunk
Here is a first pass patch that works for nodes and paragraphs. I will follow up with a patch that supports the rest of the entity types.
- πΊπΈUnited States lexfunk
This patch actually works. The patch from #3 was attempting to call `$edit_link->toRenderable` and it wasn't necessary.
- πΊπΈUnited States lexfunk
Another patch that adds the destination parameter to the link so that when you save the any changes made to the field configuration you are returned to the cm doc.
- πΊπΈUnited States swirt Florida
Thank you for the contribution @lexfunk I will try to get to reviewing this in the next couple days.
- πΊπΈUnited States swirt Florida
Hi Lexfunk this is looking pretty good.
Do we need to wrap the return in getFieldEditLink() with a check for the existence of $type_parameter_key?
It looks like $type_parameter_key is only defined if it is a node or a paragraph due to the switch case. Maybe have in intentionally return NULL if $type_parameter_key is empty, so the return can specify Link|null ( rather than Link | void ) -
swirt β
committed eeec48a6 on 1.0.x authored by
lexfunk β
Issue #3406751 by lexfunk: Include an edit link in the table that lists...
-
swirt β
committed eeec48a6 on 1.0.x authored by
lexfunk β
- Status changed to Fixed
11 months ago 3:21am 21 December 2023 - πΊπΈUnited States swirt Florida
I committed your patch @lexfunk and then followed up with a couple minor changes
- CS cleanup
- moved the access check into the getFieldEditLink() method.
- Add the link to the table for sibling fields too.
Thank you for all your work on this Lex. It is a really helpful feature.
This if fixed and will go out with 1.0.24.
- Status changed to Fixed
11 months ago 3:25am 21 December 2023 - πΊπΈUnited States swirt Florida
This has been released in 1.0.24
If you add other content types, feel free to open a new issue. It is easier to track than adding them to this issue.