- Issue created by @szloredan
- Merge request !16Issue #3406471: Allow the page limit to be overriden from request → (Merged) created by szloredan
- Status changed to Needs review
about 1 year ago 12:07pm 6 December 2023 - Status changed to Needs work
about 1 year ago 12:35pm 6 December 2023 - 🇩🇪Germany a.dmitriiev
I see one small problem, please add validation for the per page options, that every item in the comma separated list is number.
- 🇩🇪Germany a.dmitriiev
Maybe it is even a better idea to change the config schema from string to sequence of numbers and then even store it already as list of numbers in the configuration. What do you think?
- Status changed to Needs review
about 1 year ago 2:11pm 6 December 2023 - Status changed to Needs work
about 1 year ago 2:15pm 6 December 2023 - 🇩🇪Germany a.dmitriiev
I was thinking, that maybe the label of a new setting should state that this value will be exposed for UI. Moreover this setting should be actually exposed here
/api/search/{search_api_endpoint}/ui-settings
in this filemodules/ui/src/Entity/SearchApiEndpoint.php
methodgetUiSettings
and probably better as array, not a comma separated string. -
a.dmitriiev →
committed e1e806fe on 1.x authored by
szloredan →
Issue #3406471: Allow the page limit to be overriden from request
-
a.dmitriiev →
committed e1e806fe on 1.x authored by
szloredan →
- Status changed to Fixed
about 1 year ago 7:49am 14 December 2023 - 🇩🇪Germany a.dmitriiev
Thanks, the exposed items per page change was merged.
Automatically closed - issue fixed for 2 weeks with no activity.