Contrib.social

Switch from Drupal module load Include to native PHP include once for Varbase Email to include all helpers and updates

Open on Drupal.org →
Created on 4 December 2023, about 1 year ago
Updated 12 December 2023, about 1 year ago

Problem/Motivation

Follow up issue after
📌 Refactor updates for Varbase Email by moving hook updates to include/updates with load Include based on major branches Fixed

The \Drupal::moduleHandler()->loadInclude function operates slowly and necessitates the installation of the associated module to ensure proper formatting and logical functioning.

Proposed resolution

Change to

// Include all helpers and updates.
include_once __DIR__ . '/includes/helpers.inc';
include_once __DIR__ . '/includes/updates.inc';

Remove leftover conditions for if (\Drupal::moduleHandler()->moduleExists('symfony_mailer')) {
Change to 

dependencies:
  - symfony_mailer:symfony_mailer

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-9.0.17 → , varbase_email-9.0.9 → , varbase-9.1.0 → , varbase_email-9.1.1 → , varbase-10.0.0-rc1 → , varbase_email-10.0.2 →

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3405970 → by Omar Alahmed → : Switched from Drupal module load Include to native PHP include once for Varbase Email to include all helpers and updates
🐛 Bug report
Status

Fixed

Version

10.0

Component

Code

Created by

🇯🇴Jordan Rajab Natshah Jordan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024