- Issue created by @alok_singh
- Merge request !5advocate_zymphonies_theme-3405917: Need to change twitter logo to 'X'. → (Open) created by alok_singh
- Status changed to Needs review
about 1 year ago 10:43am 4 December 2023 - Assigned to Sandeep_k
- Issue was unassigned.
- Status changed to RTBC
12 months ago 3:39pm 3 January 2024 Verified MR5 on 9.5.x, the twitter icon is updated. Added screenshots for reference, RTBC++
- Status changed to Needs work
11 months ago 6:20am 8 February 2024 - 🇮🇳India hamid.ali
@alok_singh Instead of adding the Twitter icon directly in the markup kindly add it using the existing way i.e. using the font awesome library to maintain the project consistency. I am moving this to needs work status for now. Additionally adding the screenshot below
- Status changed to Needs review
10 months ago 5:19am 22 February 2024 - 🇮🇳India alok_singh
@hamidali, For single icon we don't use cdn link because of this will cause loading issue in the site.
Please learn more, then implement.
And try to create MR not a patch. - 🇮🇳India hamid.ali
@alok_singh adding svg image directly is not following the coding standards since all the icons are added using font awesome. Thats why I pointed the same. Kindly go through the code once and check the coding standards no icon has been added directly as a svg within the markup.
- Status changed to RTBC
5 months ago 10:33am 15 July 2024 - 🇮🇳India riddhi.addweb
The mentioned issue is resolved, & I have also checked it in the Simplytestme sandbox and it is working as expected. I am attaching the Screenshots & doing RTBC for the same.