Contrib.social

Be able to add image to banner via module configuration

Open on Drupal.org →
Created on 4 December 2023, 7 months ago
Updated 26 December 2023, 6 months ago

Problem/Motivation:

I wanted to be able to set an logo/image into my banner via the modules settings page

Steps to reproduce

Apply the patch and you can use the image in template with help of "twig_tweak"

Proposed resolution

Add new field to the settings form that allows images to be uploaded

Remaining tasks

Testing

User interface changes

API changes

Data model changes

✨ Feature request
Status

Needs work

Version

1.24

Component

Code

Created by

🇳🇱Netherlands bram.velthoven

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Issue created by @bram.velthoven
  • Comment 7 months ago →
    🇳🇱Netherlands bram.velthoven

    I noticed that the managed_file sets the file as temporary. Thats why i added a little code that makes sure the added image is a permanent. Here is the renewed patch.

  • Status changed to Needs work 6 months ago
  • Comment 6 months ago →
    🇮🇳India Prashant.c Dharamshala

    @bram.velthoven

    I have few queries:

    1. The uploaded file you want to set as the banner background image?
    2. IMHO If its required then the rendering part should also be within the module code itself, apart from using third party modules like twig_tweak etc.

    I have pushed the changes from the patch file to the issue fork, please make changes in the existing MR itself.

    Thanks!

  • Merge request !133Code refactor → (Open) created by Prashant.c
contrib.social Blog FAQ Discussions
Production build 0.69.0 2024