Misc PHP errors to fix for D10 compatibility

Created on 1 December 2023, 7 months ago

Updated 2 December 2023, 7 months ago

Problem/Motivation

I am seeing a few issues when trying to add the "Paykings" Gateway:

TypeError: Drupal\commerce_paykings\Plugin\Commerce\PaymentGateway\PayKingsFrame::__construct(): Argument #8 ($payKingsRestApiClient) must be of type Drupal\commerce_paykings\Client\PayKingsRestApiClientInterface, Drupal\commerce_paykings\Client\PayKingsClient given, called in /var/www/html/web/modules/contrib/commerce_paykings/src/Plugin/Commerce/PaymentGateway/PayKingsFrame.php on line 127 in Drupal\commerce_paykings\Plugin\Commerce\PaymentGateway\PayKingsFrame->__construct() (line 87 of /var/www/html/web/modules/contrib/commerce_paykings/src/Plugin/Commerce/PaymentGateway/PayKingsFrame.php).

Steps to reproduce

- Install the commerce_paykings module, try to add a new gateway, select "Paykings (Credit Card)" or "PayKings Frame"

Proposed resolution

- Fix the D10 compatibility issues

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇨🇦Canada danrod

Live updates comments and jobs are added and updated live.

Merge Requests

!1Misc PHP errors to fix for D10 compatibility
Merged
🇨🇦Canada danrod
updated 7 months ago

Comments & Activities

Issue created by @danrod
Assigned to danrod
Comment 7 months ago →
🇨🇦Canada danrod
Merge request !1Issue # 3405613 by danrod: Fixes for misc PHP errors to fix for D10 compatibility → (Merged) created by danrod
Comment 7 months ago →
🇨🇦Canada danrod
After applying these fixes, I was able to add the payment gateways with no issues:
Status changed to Needs review 7 months ago11:06pm 1 December 2023
Comment 7 months ago →
🇨🇦Canada danrod
Status changed to Fixed 7 months ago2:19am 2 December 2023
Comment 7 months ago →
🇨🇦Canada danrod
The latest D10 release fixes these issues: https://www.drupal.org/project/commerce_paykings/releases/8.x-1.2 →
Comment 7 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024