Computed fields should not be embeddable fields or source suggestions

the attached patch excludes computed fields in the following:

• \Drupal\tmgmt_content\Plugin\tmgmt\Source\ContentEntitySource::getEmbeddableFields()
• tmgmt_content_tmgmt_source_suggestions()

The last submitted patch, 2: tmgmt_content-3405309-2.patch, failed testing. View results →

I added a new hook_tmgmt_content_source_suggestion_fields_alter in order to make the return from tmgmt_content_tmgmt_source_suggestions more flexible for other modules to exclude suggestions. Example: exclude all entity reference field for a specific target type that should not be available as a suggestion. The alter hook is needed since there is no source_suggestions alter and even if there was, it would be too late since tmgmt_content_tmgmt_source_suggestions already loaded all the entities for the reference field which is detrimental if that field is storing 100s of references.

To verify the last patch from this issue I followed the steps from #3399032 with the metatag module and I still see the "meta" fields in the export despite the fact that they are computed.

Maybe I am doing something wrong or something changed in the metatag module in the meantime

Rerolled against the latest 1.x, converted to MR while I was at it.