Update the FieldType category for clarity

Result of the change:

I think we need the yaml file too, for the category as the UI you have shown is gone in 10.1

I'd consider instead to move DER into the reference category. I'm doing the same in ERR in 📌 Move field type into Reference group in new Drupal 10.2 field UI Needs work (and in turn, Paragraphs is moved to a top-level item). Is DER really used often enough to warrant a top-level option?

Looking at the changes, I think that's exactly what you did already, you just didn't consider backwards compatibility for 10.1 and older. You could do an alter hook with a version like 🐛 Fix "Using a translatable string as a category for field type" deprecation in Drupal core 10.2 Active already did or just don't bother and live with it in 10.1 and lower.

No, the code I was looking at is old and doesn't do anything anymore on 10.2.

Had a look at the ERR issue and DER a bit as well.

So what I'd propose is dropping \Drupal\dynamic_entity_reference\Plugin\Field\FieldType\DynamicEntityReferenceItem::getPreconfiguredOptions(), or more specifically, return an empty array. Right now it uses the same common target options as entity reference, which duplicates all options in the same section with identical labels, so it's impossible to see which you want to take.

You could also add a suffix, but I think none of these cases are "common" and you'll select more than one option anyway in pretty much all cases.

Pushed my suggestions to the MR. Wasn't sure about changing the visible label like I did for ERR ("Other (revisions)"), feel free to copy paste more from there.

I think we can drop 10.1 support for next release.

Your call, but 10.2 only came out very recently and 10.1 is still supported until June, that IMHO is very early to drop support (It's only a confusing UI but still)

I think we can drop 10.1 support for next release. Meanwhile we can leave a patch for 10.1 here if we still need it.

I am happy to keep both versions for now

I think we can drop 10.1 support for next release. Meanwhile we can leave a patch for 10.1 here if we still need it.

I am happy to keep both versions for now

I'm not sure this is working on 10.1 though as it stands?

Ignore that ^ wrong branch

Manually tested this on 10.1.x and 11.x and its way better, merged - thanks

Automatically closed - issue fixed for 2 weeks with no activity.