Contrib.social

Non-static method should not be called statically

Open on Drupal.org →
Created on 29 November 2023, over 1 year ago
Updated 30 November 2023, over 1 year ago

Problem/Motivation

The module uses first-class callable syntax like this in many of its forms:

      '#validate' => [
        $this::validateListForm(...),
      ],
      '#submit' => [
        $this::submitDeleteRecord(...),
      ],

However, you can't use $this:: unless it's a static function. The PHP documentation shows this:

$obj = new Foo();
$classStr = 'Foo';
$methodStr = 'method';
$staticmethodStr = 'staticmethod';


$f1 = strlen(...);
$f2 = $obj(...);  // invokable object
$f3 = $obj->method(...);
$f4 = $obj->$methodStr(...);
$f5 = Foo::staticmethod(...);
$f6 = $classStr::$staticmethodStr(...);

So it should be $this->validateListForm(...), etc.

Proposed resolution

Convert all the first-class callable functions to use the non-static syntax if the function isn't static.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

4.1

Component

Code

Created by

solideogloria

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024