Do not add a placeholder for the view if cookies already accepted

Open on Drupal.org →

Created on 29 November 2023, about 1 year ago

Problem/Motivation

Currently, we didn't check cookies before adding a placeholder to the view. So, the placeholder always renders on the page and after that replaced by the view if cookies are accepted. It can cause some late view rendering which could affect page scrolling.

Proposed resolution

Add check, before adding a placeholder, if exists cookies for the current service.

✨ Feature request

Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!2Do not add a placeholder for the view if cookies already accepted
Merged
🇺🇦Ukraine _shy
updated about 1 year ago

Comments & Activities

Issue created by @_shy
Merge request !2Issue #3404829 by _shY: Do not add a placeholder for the view if cookies already accepted → (Merged) created by _shy
Status changed to Needs review about 1 year ago7:46am 29 November 2023
Comment about 1 year ago →
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Comment about 1 year ago →

_shY → committed af864563 on 1.0.x

Issue #3404829 by _shY: Do not add a placeholder for the view if cookies...

Status changed to Fixed about 1 year ago9:02am 29 November 2023
Comment about 1 year ago →
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024