Contrib.social

Read from reverse_proxy_addresses not reverse_proxies

Open on Drupal.org →
Created on 28 November 2023, about 1 year ago
Updated 1 January 2024, about 1 year ago

Problem/Motivation

The constructor of the Drupal\acquia_purge\AcquiaCloud\PlatformInfo class reads from a setting called reverse_proxies. But it is actually reverse_proxy_addresses. This isn't a D7-ism either, the value was always the same name. For finding and reporting the issue, the credit goes to Matt Glaman.

Steps to reproduce

  1. In your settings.php file uncomment these lines:

    $settings['reverse_proxy'] = TRUE;

    $settings['reverse_proxy_addresses'] = ['a.b.c.d', 'e.f.g.h/24'];
  2. In your debugger set a breakpoint at \Drupal\acquia_purge\AcquiaCloud\PlatformInfo::__construct()
  3. On the /admin/config/development/performance/purge page try to add an „Acquia Cloud” type of purger plugin
  4. The debugger shows that variable reverse_proxies does not get a value which is bad:

Proposed resolution

Fix the naming mistake when reading from site settings.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇭🇺Hungary Balu Ertl Budapest 🇪🇺

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024