- Issue created by @estebanvalerio.h
- 🇨🇷Costa Rica estebanvalerio.h
I created a patch using drupal-rector and grabbing the files it modified, after flushing cache and using Upgrade Status → , it recognizes the module as a compatible D10 one.
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 5:57am 28 November 2023 - 🇨🇷Costa Rica estebanvalerio.h
While testing the project where I'm using this module I found an error:
Drupal\Core\Entity\Query\QueryException: Entity queries must explicitly set whether the query should be access checked or not. See Drupal\Core\Entity\Query\QueryInterface::accessCheck(). in Drupal\Core\Entity\Query\Sql\Query->prepare() (line 141 of /app/public_html/core/lib/Drupal/Core/Entity/Query/Sql/Query.php).
I noticed in this module, some entity queries are run and needed that line, so I create a new patch for it.
- First commit to issue fork.
- Status changed to RTBC
5 months ago 11:27am 29 August 2024 - First commit to issue fork.
-
krystalcode →
committed 78bfacfd on 8.x-1.x
Issue #3404466 Removed multiple calls to access check Already called...
-
krystalcode →
committed 78bfacfd on 8.x-1.x
-
krystalcode →
committed 2065f371 on 8.x-1.x
Issue #3404466 Be explicit with access check calls
-
krystalcode →
committed 2065f371 on 8.x-1.x
-
krystalcode →
committed 6c53b60c on 8.x-1.x
Issue #3404466 Corrected method declaration to match interface
-
krystalcode →
committed 6c53b60c on 8.x-1.x
-
krystalcode →
committed 6b1ae45a on 8.x-1.x
Issue #3404466 Corrected order of use statements
-
krystalcode →
committed 6b1ae45a on 8.x-1.x
- 🇵🇪Peru krystalcode
Merged into the main development branch. I will close and make a release after this has been tested on a project for some time to make sure we don't have any regressions.
Notes:
- I changedaccessCheck()
toaccessCheck(TRUE)
; I prefer to be explicit with access control, it makes it easier to read if you don't remember what is the default.
- Removed a duplicate call to access check, kept the one before the subscriber so that subscribers can change it if they have a legitimate reason.
- I reverted the change in the declaration ofpublic static function getSubscribedEvents()
to match that of the interface - seeSymfony\Component\EventDispatcher\EventSubscriberInterface
.
- Good with removing Drupal 8 support, event dispatching is not compatible anymore.Thanks!
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
@krystalcode return typehints can be more explicit than the interface. Reverting that just means you'll have to do it for Drupal 11 compatibility.
- 🇵🇪Peru krystalcode
@alexpott why would that be the case? Drupal 11 relies on Symfony 7 (https://git.drupalcode.org/project/drupal/-/blob/11.x/core/composer.json...) which also has the same method declaration (https://github.com/symfony/event-dispatcher/blob/7.1/EventSubscriberInte...).