Add getType to StageBase to allow subclasses to be internal

I'm pretty much happy with this, although it occurs to me that we could make type() a protected property or class constant, rather than a method, and still keep our rules about subclasses overridding it (\ReflectionProperty and \ReflectionClassConstant both have the getDeclaringClass() method).

The only downside is that it would no longer have any dynamism, but I'm honestly not sure if we really need that anyway.

@phenaproxima re #5 I changed this to protected string. I agree it simpler.

The only downside is that it would no longer have any dynamism, but I'm honestly not sure if we really need that anyway.

As long as it is not a constant it can still be somewhat dynanmic.

for instance we could have have our attended and unattended stages be one class with 2 different services using this class. Just add a $more property to the constructor and in the constructor set the $this->type value.

Couple of small things but this otherwise looks good to me.

Accepted suggestions and 1 more cleanup

One suggestion but RTBC overall.

ugh the test failure I think is 🐛 Possible random failure in build tests for cron updates Postponed . 3.0.x is passing after the merge

Automatically closed - issue fixed for 2 weeks with no activity.