Call to a member function buildUrl() on null

Created on 26 November 2023, about 1 year ago

Problem/Motivation

Calling Twig function styled_image_url or ResponsiveImageStylesTwigExtension::getStyledImageUrl with an inexisting style name causes the following error:

Error: Call to a member function buildUrl() on null in Drupal\pagedesigner_responsive_images\ResponsiveImageStylesTwigExtension->getStyledImageUrl() (line 143 of modules/contrib/pagedesigner_responsive_images/src/ResponsiveImageStylesTwigExtension.php).

Proposed resolution

To reduce the risk of fatal errors in production, return the default url if style does not exist.

Remaining tasks

Review MR

User interface changes

None

API changes

ResponsiveImageStylesTwigExtension::getStyledImageUrl will return default image url if style does not exist.

Data model changes

None

🐛 Bug report

Status

Fixed

Version

3.0

Component

Code

Created by

🇨🇭Switzerland pvbergen

Live updates comments and jobs are added and updated live.

Merge Requests

!22Call to a member function buildUrl() on null
Merged
🇨🇭Switzerland pvbergen
updated about 1 year ago

Comments & Activities

Issue created by @pvbergen
Merge request !22Return default url if given style does not exist → (Merged) created by pvbergen
Status changed to Needs review about 1 year ago8:26pm 26 November 2023
Comment about 1 year ago →
🇨🇭Switzerland pvbergen
Status changed to Fixed about 1 year ago10:04pm 26 November 2023
Comment about 1 year ago →
🇨🇭Switzerland pvbergen
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024