Classic Admin Toolbar styles broken on LB pages

Open on Drupal.org →

Created on 25 November 2023, about 1 year ago

Problem/Motivation

There is a gap between the main toolbar and the secondary toolbar. The Display Options drop-down (that provides the toggle for previewing regions and previewing content) is broken. The "Save" button sits all the way to the left of the screen with no padding.

Steps to reproduce

In the Gin settings, enable the "Legacy, Classic Drupal Toolbar".

Proposed resolution

The patch adds a new component stylesheet for "_classic_toolbar_secondary" that adds CSS rules to handle the breadcrumbs and Display Options dropdown. It does not solve the problem in keeping with the "classic" toolbar style, but rather borrows from the newer Gin style. However, it looks a lot better than the current version.

Remaining tasks

Potentially re-work the stylesheet to better mimic the "Classic" toolbar style.

🐛 Bug report

Status

Active

Version

1.0

Component

Code

Created by

🇺🇸United States jessehs Taos, New Mexico

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @jessehs
Comment about 1 year ago →
🇺🇸United States jessehs Taos, New Mexico
This patch is a "work in progress". It contains a few commented-out styles that may be helpful for debugging or testing out improvements.
Comment about 1 year ago →
🇬🇧United Kingdom arcaic Milton Keynes
Just adding a me too here so not much real help.

All our sites that use the Legacy Classic Toolbar (3 or 4) are seeing this issue.

Haven't been able to see whats wrong but for now we have switched to using the Horizontal Modern Toolbar and enabling "Show Secondary Toolbar in Frontend".

Andy
Status changed to Needs work 11 months ago2:46pm 5 February 2024
Comment 11 months ago →
🇫🇷France Grimreaper France 🇫🇷
Comment about 1 month ago →
🇺🇸United States hungdo
Re-roll patch for the version 1.0.0-rc8

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024