Contrib.social

Using height:100% on the iframe wont work if the iframe is not the only element in the parent wrapper

Open on Drupal.org →
Created on 24 November 2023, over 1 year ago

Problem/Motivation

iframe.subman-embed gets a height of 100% in the iframe.embed.css. This is a bad idea, because 100% height means, 100% height of the parent wrapper. So if the iframe is not the only element there, this will break.

Steps to reproduce

Proposed resolution

Solution 1) Wrap the iframe into its own wrapper
Solution 2) Limit the selector to iframe.subman-embed:only-child
Solution 3) Remove the height:100% as it seems unnecessary as it also has a min-height of 135em

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

thomas.frobieter EU

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024