- Issue created by @douggreen
- Status changed to Needs review
12 months ago 6:56pm 23 November 2023 - last update
12 months ago Patch Failed to Apply - 🇫🇷France flocondetoile Lyon
Hello. Why not let the logBlockedSubmission() in the native condition and just add an hook if the protection is trigerred ?
- 🇫🇷France flocondetoile Lyon
Also, why use \Drupal::moduleHandler()->invokeAll().
\Drupal::moduleHandler()->alter() looks the right way to perform this no.And if we use the module_handler service, we need to inject it in the manager.
- Status changed to Needs work
9 months ago 10:03am 21 February 2024 - 🇺🇸United States douggreen Winchester, VA
In response to #3 - You could keep logBlockedSubmission in the native condition, that's a design choice. I like using my own hooks as it shows other developers how to use them.
In response to #4 - we aren't altering anything, I think invokeAll is the correct method. And yes, we should inject the module_handler.