- Issue created by @Grimreaper
- First commit to issue fork.
- Merge request !20Issue #3403793 by pdureau, vmaucorps: From one CSS variable plugin generate derivatives β (Open) created by niber
- Assigned to niber
- Status changed to Needs work
5 months ago 3:19pm 25 July 2024 - Issue was unassigned.
- Status changed to Needs review
5 months ago 6:43pm 25 July 2024 - Assigned to niber
- Status changed to Active
5 months ago 12:35pm 26 July 2024 Adding disabled informative fields for each derivative css variables in UI.
For now, only support Hex to RGB and RGB to Hex transformation, the issue stays active.
An example format for Yml configuration :bs_primary: category: "Colors" type: "color" label: "Primary" default_values: ":root": "#0d6efd" weight: 1 derivatives: bs_primary_rgb: transformation_plugin_id: "hex_to_rgb" bs_secondary_bg_rgb: transformation_plugin_id: "hex_to_rgb"
- Issue was unassigned.
- Status changed to Needs review
5 months ago 7:38am 29 July 2024 - π«π·France pdureau Paris
Hello,
Do we need to make the transformation visible from the UI ? It is an low-level API stuff, the site administrator doesn't care about the design system having "aliases" for CSS variables.Cordiale
- Assigned to Grimreaper
- πΊπΈUnited States bunthorne
I don't know if this is helpful, but from a simplistic perspective of a site builder with minimal needs it would be great to be able to choose just the primary and secondary colors that would generate all of the relevant color choices, or even a third color if that is part of the set. Is that the goal of this issue?
- π«π·France Grimreaper France π«π·
Hi,
@bunthorne, it is the goal of this issue.
- Issue was unassigned.
- Status changed to Needs work
5 months ago 1:49pm 1 August 2024 - π«π·France Grimreaper France π«π·
Thanks for your work, with MR, screenshot and code example.
See my code review comment, which is aligned with comment 15.
I opened an issue on UI Suite Boostrap β¨ POC CSS variables derivative Active to put the POC in parallel of the transformation plugins created here, so easier for people to test and have a concrete example.
- Status changed to Active
4 months ago 3:19pm 6 August 2024 Hello, thanks for the review !
I removed the disabled fields showing derivatives, and changed a a bit the structure of the ui_skins.css_variables.yml :
bs_primary: category: "Colors" type: "color" label: "Primary" default_values: ":root": "#0d6efd" weight: 1 derivatives: bs_primary_rgb: "hex_to_rgb": - key1: 'value1' - key2: 'value2' - key3: 'value3' bs_secondary_rgb: "hex_to_rgb": {}
We are now able to pass configuration options to our derivative variables.
- Status changed to Needs review
4 months ago 7:13am 7 August 2024 - Assigned to niber
- Status changed to Active
4 months ago 8:02am 12 August 2024 - Issue was unassigned.
- Status changed to Needs review
4 months ago 12:34pm 12 August 2024 - Assigned to Grimreaper
- Status changed to Needs work
4 months ago 4:12pm 29 August 2024 - π«π·France Grimreaper France π«π·
Updated MR to have it working as intended.
Now needs work based on all the transformers needed for UI Suite Bootstrap. and Needs tests
- Issue was unassigned.
- π«π·France Grimreaper France π«π·
Currently not working on it.
Finishing other issues of ui_suite_bootstrap and other more important issues before coming back here.