- Issue created by @arthur_lorenz
- Status changed to Needs review
7 months ago 3:24pm 23 November 2023 - π³π±Netherlands roderik Amsterdam,NL / Budapest,HU
I don't know if I should set Needs Work, Needs more info or just test it myself (not sure about my allocated time anymore).
I guess I'll rely on an actual module maintainer to do whatever.
- π¦πΉAustria arthur_lorenz Berlin
but I'm kind-of weirded out by the notion that anonymous/authenticated roles would not exist
In the end both roles are just some config. If the config was not yet applied, the roles won't exist. But I should add the user module as dependency.
and a little afraid that now they won't get the "restful get rest_menu_item" permission assigned as they should.
don't be :) Usually this should only occur during site install with existing config. Then the permission should be applied in the config files and imported later on. Otherwise the roles should already exist. If not there might be a reason for it and it should not fail.
But I'm wondering if it makes more sense to check the `$is_syncing` and skip the step if it's true to not mess with any config.
- Status changed to RTBC
7 months ago 11:12am 27 November 2023 - π³π±Netherlands roderik Amsterdam,NL / Budapest,HU
Right. Thank you for clarifying :-) I should have kept $is_syncing in mind.
The explanation + the scope of the change (only when $is_syncing, which previously had an error) enables to RTBC after just reviewing code.
- First commit to issue fork.
-
fago β
committed a1a3166e on 1.x authored by
arthur_lorenz β
Issue #3403787 by arthur_lorenz, roderik: lupus_decoupled_menu install...
-
fago β
committed a1a3166e on 1.x authored by
arthur_lorenz β
- Status changed to Fixed
7 months ago 11:43am 28 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.