Contrib.social

De-duplicate code in twig templates

Open on Drupal.org →
Created on 23 November 2023, almost 2 years ago
Updated 9 July 2024, over 1 year ago

The code in block--lb-hero--variation-*.html.twig contains highly duplicated code. In order to maintain a DRY codebase and reduce our codebase “weight”, we should de-duplicate code wherever possible.

A possible model for this could be:

  • block--lb-hero.html.twig contains the base code for all variants with block statements and switching logic.
  • set statements should all be made before any div to maintain separation of concerns.
  • block--lb-hero--variation-*.html.twighave set statements to assign variables, then use extends to reference the base template.

Acceptance Criteria

  • code diff should have lots of deletions
  • front-end should have no changes from prior behavior
📌 Task
Status

Fixed

Version

1.2

Component

Code

Created by

🇺🇦Ukraine david-b Kropyvnytskyi

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024