- Issue created by @mrhorse
- Status changed to Needs review
12 months ago 12:47pm 23 November 2023 - last update
12 months ago 1 pass - last update
12 months ago 1 pass - 🇮🇳India shubhangi1995 GURGAON
Even after above patch one issue is left :
Line tests/src/Functional/GTMMultipleTest.php
------ ---------------------------------------------------------------------------------------------------------------------------------------------------------
10 Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055 → , which includes recommendations on which theme to use.
------ ---------------------------------------------------------------------------------------------------------------------------------------------------------Providing patch with all deprications
- last update
12 months ago 1 pass - Status changed to RTBC
11 months ago 11:34pm 10 December 2023 - 🇬🇧United Kingdom mrhorse
Thanks for adding that last bit. Working well for me thanks :)
- Issue was unassigned.
- Status changed to Active
9 months ago 2:16am 3 March 2024 - 🇺🇸United States solotandem
IMHO, the claims in the issue summary are false. Instead, the 1.x branch:
- does support 10.2.x
- does NOT require a patch to run in 10.2.x
- the 'appropriate changes suggested by upgrade_status' are all false positives.
The patch provided on this issue is not needed:
- accessCheck() does not apply to query run on a config entity
- call to file_url_transform_relative() only runs if file_url_generator service is not present (e.g. drupal 8)
- defaultTheme property is set
If you can demonstrate to the contrary, please do so.
- First commit to issue fork.