- Issue created by @shiks
- ๐บ๐ฆUkraine abramm Lutsk
Hi Shikha_LNweb,
Can you please provide the example HTML content? - ๐บ๐ฆUkraine nginex
As far as I know we support embedded media in ckeditor, so if itโs img tag, then itโs not supported yet
- ๐ฎ๐ณIndia shiks
@abramm
Apologies for delays in response.
Example :
<img src="https://.../files/inline-images/Screenshot%202023-11-22%20at%2011.06.00%20AM.png" data-entity-uuid="084c5cf5-c2b5-4243-81ed-7d6d0cd0c300" data-entity-type="file" width="50"> <p> Testing </p>
- ๐ฎ๐ณIndia shiks
@nginex
Yes, I am using img tag. Can you please confirm if there is some patch available or some plans to support the embedded img tag soon ?
- ๐บ๐ฆUkraine abramm Lutsk
This looks like you're using the entity_embed module; can you please confirm that?
- ๐บ๐ฆUkraine abramm Lutsk
Images inserted via
entity_embed
aren't supported right now. Theentity_embed
is a third party contrib module which does inline images processing in its own way.This is not a bug, so I'm changing this to feature request; we might support this in future if someone would be interested in implementing it.
- ๐ฎ๐ณIndia shiks
Let me put some time on it and try creating a patch for it . @abramm
- ๐บ๐ฆUkraine abramm Lutsk
We're not your personal developers army @Shikha_LNweb, I'd be happy to review the MR adding the feature you need if you'd submit one.
- ๐ฎ๐ณIndia nikhil_dawar
I've completed the patch that enables the import/export of embedded images through SCS as per above-mentioned request.
Thank you - Status changed to Needs review
about 1 year ago 7:35am 1 December 2023 - Status changed to Needs work
about 1 year ago 9:21am 1 December 2023 - ๐บ๐ฆUkraine abramm Lutsk
Hi nikhil_dawar,
Thank you for the patch!
Can you please create the MR? We have some tests and automatic checks that I'd like to see before we move forward.
Also I can see you've commented out a part of code; we don't keep dead code in repository so let's remove it altogether. - ๐ฎ๐ณIndia manpreet_singh
Manpreet_Singh โ changed the visibility of the branch 3403294-support-exporting-images to hidden.
- ๐ฎ๐ณIndia nikhil_dawar
Hi abramm, here I have removed the dead code from the patch