- Issue created by @moshe weitzman
- Status changed to Needs review
10 months ago 6:23pm 21 November 2023 - πΊπΈUnited States moshe weitzman Boston, MA
Follows the pattern of https://www.drupal.org/project/drupal/issues/3398321 π Optimize GitLab resource requests phase 1 Fixed (drupal core)
- Status changed to Needs work
10 months ago 7:00pm 21 November 2023 - π³π±Netherlands bbrala Netherlands
I would start with 2 for phpstan also. Modules are generally very small. Other than that, 2 sounds fine.
- Status changed to RTBC
10 months ago 7:38pm 21 November 2023 - π³π±Netherlands bbrala Netherlands
This should be fine. If I understand the infra correctly this will speed up jobs and use way les resources.
There might be some modules that see increase in testtimes. But I'd rather let that happen and either specifically up resources there or tweak based on feedback.
Rtbc
- Status changed to Needs work
10 months ago 8:27am 22 November 2023 - πͺπΈSpain fjgarlin
The new variable should be added in
include.drupalci.variables.yml
in my opinion. Core also uses this file but it is a good-enough default value and also core overrides this value per job.Once it's moved I think it's good to go.
- π³π±Netherlands bbrala Netherlands
Great cleanup, that looks a lot better :)
- Status changed to Needs review
10 months ago 9:11am 22 November 2023 - Status changed to RTBC
10 months ago 10:08am 22 November 2023 - π³π±Netherlands bbrala Netherlands
Thoroughly testen by fjgarlin. Looks great. Let's save some resources <3
-
fjgarlin β
committed 506a1842 on 1.0.x authored by
moshe weitzman β
Issue #3403212 by moshe weitzman, fjgarlin, bbrala: Customize resource...
-
fjgarlin β
committed 506a1842 on 1.0.x authored by
moshe weitzman β
- Status changed to Fixed
10 months ago 10:10am 22 November 2023 - πͺπΈSpain fjgarlin
Merged! Less waiting time and less resources, it's a total win-win.
Thanks! -
fjgarlin β
committed db0ce77e on 1.0.x
Revert "Issue #3403212 by moshe weitzman, fjgarlin, bbrala: Customize...
-
fjgarlin β
committed db0ce77e on 1.0.x
- Status changed to Needs work
10 months ago 1:25pm 22 November 2023 - π³π±Netherlands bbrala Netherlands
Appearantly global vars do not play nice with child pipelines and such. We need to EXPLICITLY set them on the jobs instead so we dont break core.
- π³π±Netherlands bbrala Netherlands
See https://drupal.slack.com/archives/CGKLP028K/p1700658667684839 for report
Weirdness explained in gitlab issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357275
So, basically, we need to set the vars on the jobs themselves.
- πͺπΈSpain fjgarlin
I'll go with the approach that Moshe did initially, which was to include it in the "includes/include.drupalci.main.yml" file instead. That affects only "contrib" space. I'll also add it to the D7 file.
- Status changed to Needs review
10 months ago 2:31pm 22 November 2023 - πͺπΈSpain fjgarlin
I moved the code to the files that are only used by contrib.
MR: https://git.drupalcode.org/project/gitlab_templates/-/merge_requests/88 - Status changed to RTBC
10 months ago 8:16pm 22 November 2023 - π³π±Netherlands bbrala Netherlands
Yeah, the yaml will not be included in core. And since we do not use the weird child pipeline setup in contrib this should actually be fine.
Sorry for missing the weirdness in overwriting in child pipelines. ;x
-
fjgarlin β
committed 4c954c51 on 1.0.x
Issue #3403212 by fjgarlin, moshe weitzman, bbrala: Customize resource...
-
fjgarlin β
committed 4c954c51 on 1.0.x
- Status changed to Fixed
10 months ago 8:27am 23 November 2023 - πͺπΈSpain fjgarlin
Ok, merged.
Thanks again for patience, feedback, understanding... hopefully, we will start to see the difference in contrib now after this change. Automatically closed - issue fixed for 2 weeks with no activity.