- Issue created by @pingwin4eg
- Status changed to Needs review
over 1 year ago 6:49am 23 November 2023 - Status changed to Needs work
over 1 year ago 10:27am 8 December 2023 - 🇺🇦Ukraine pingwin4eg Zaporizhia 🇺🇦
DrupalPractice code sniffing standard revealed more errors and warnings to fix.
- Assigned to nitin_lama
- 🇮🇳India nitin_lama India
WARNING | Global constants should not be used, move it to a class or interface
To address this warning, one possible solution is to create a distinct class for the constants and subsequently employ that class within the .module. I refrained from pushing the modifications as there is only a single constant variable. I am uncertain whether it is acceptable to disregard the warning or if it is necessary to establish a separate class to resolve it.
- Issue was unassigned.
- 🇮🇳India nitin_lama India
I think nightwatch tests are failing. Therefore readding WebAssert warning fix.
- Assigned to pingwin4eg
- 🇺🇦Ukraine pingwin4eg Zaporizhia 🇺🇦
Thanks @nitin_lama for working on this.
I'll continue from here.
The Nightwatch testing fail seems unrelated.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:39am 15 December 2023 - 🇺🇦Ukraine pingwin4eg Zaporizhia 🇺🇦
Auto-tests pass. Manual testing remains.
-
pingwin4eg →
committed f22d62bc on 8.x-2.x
Issue #3403145 by pingwin4eg, nitin_lama: Fix coding standards
-
pingwin4eg →
committed f22d62bc on 8.x-2.x
- Status changed to Fixed
over 1 year ago 8:39am 19 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.