Contrib.social

Implement dependency injection in all places

Open on Drupal.org →
Created on 21 November 2023, 7 months ago
Updated 3 January 2024, 6 months ago

There are a few places that uses \Drupal calls in classes. We should avoid it.

🐛 Bug report
Status

Needs review

Version

2.0

Component

Code

Created by

🇺🇦Ukraine AstonVictor

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @AstonVictor
  • Merge request !43403128 - Fix services → (Open) created by AstonVictor
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 7 months ago
    Waiting for branch to pass
  • Issue was unassigned.
  • Status changed to Needs review 7 months ago
  • Comment 7 months ago →
    🇺🇦Ukraine AstonVictor

    Created a new MR.

    While working found that we cannot add dependency injection to ParagraphEditForm class because it requires adding content_translation module as a dependency.
    in that case, I moved all code from the init() method to hook_ENTITY_TYPE_prepare_form() function.

  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 7 months ago
    Waiting for branch to pass
  • Comment 6 months ago →
    🇳🇱Netherlands bbrala Netherlands

    I'm gonna defer this review to another developer. ;x

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024