- Issue created by @alok_singh
- Merge request !1beauty_salon_zymphonies_theme-3403054: Change twitter icon to X. → (Open) created by alok_singh
- Status changed to Needs review
about 1 year ago 9:00am 21 November 2023 - Status changed to RTBC
12 months ago 5:29pm 27 November 2023 Verified MR1 on 9.5.x, the twitter icon is changed to "X". Added screenshots for reference, RTBC++
- Status changed to Needs review
9 months ago 6:31am 14 February 2024 - 🇮🇳India hamid.ali
@alok_singh @tanuja since we can't add the logo directly as an SVG to maintain consistency. Since we are using the Font Awesome library we need to update the Twitter logo using that only. I am attaching the patch along with the screenshot.
After Patch:
- 🇮🇳India alok_singh
@hamidali, For single icon we don't use cdn link because of this will cause loading issue in the site.
Please learn more, then implement.
And try to create MR not a patch. - 🇮🇳India hamid.ali
@alok_singh adding svg image directly is not following the coding standards since all the icons are added using font awesome. Thats why I pointed the same. Kindly go through the code once and check the coding standards no icon has been added directly as a svg within the markup.
- 🇮🇳India riddhi.addweb
I have tried MR#1 & 3403054-5 both patches, and both work for us. The mentioned page issue is resolved, & I have also checked and it is working as expected. Attaching the Screenshots & doing RTBC for the same.
- Status changed to RTBC
6 months ago 12:26pm 28 May 2024