- Issue created by @smustgrave
- Status changed to Closed: outdated
over 1 year ago 9:02pm 9 December 2023 - 🇺🇸United States smustgrave
collection
Items is a "rendable array of items" but the preview has only one item. So:
maybe the description is wrong, and the preview must not be a sequence
maybe a second item is expected in the preview
Also, careful with "rendable" typo
You don't use the default attributes object but the custom list_attributes prop instead. Why?
collection_item & collection_item_meta_tags
I have the feeling all those components (collection, collection_item, collection_item_meta_tags...) can be merged and simplified.
Because, they have many issues and it may be the result of overengineering:
Testing the render array structure in template may be harmful:
{% if meta_items_list['#sources'] is defined %}
...
{% if meta_items_list['#type'] is defined %}
Normally, slots content are opaque.
In collection_item_meta_tags
We are not using the attributes object here.
Don't do premature rendering: meta_item|render|striptags|trim
Closed: outdated
3.0
Code