- Issue created by @amstercad
- πΊπΈUnited States amstercad
In components/form/form.twig, replacing this line:
{% set form_utility_classes = form_utility_classes ? form_utility_classes : [] %}
with this line allows the website to render again:
{% set utility_classes = utility_classes ? utility_classes : [] %}
I'd submit a patch to change it back, but I'm not sure what you were trying to achieve.
Lee is there any template that is passing utility_classes to form.twig? since simply renaming a variable shouldn't break the whole thing and since we are still on the dev branch, we are not that much backward compatible though
the reason for name changing is to be clear on what a utility class is used for
- πΊπΈUnited States amstercad
"utility_classes" are called from all over the place. For example this .yml file.
Does changing
utility_classes
toform_utility_classes
in the yml file and clearing the cache fixes the issue?Also that utlity_classes coming from nav component and not from the form component
I believe the error you are getting is not related to the class changes
- πΊπΈUnited States amstercad
I created a clean Drupal site with only Radix 6.0.x and the rendering fails with the same error as written above. That's what I can report for the moment.
- πΊπΈUnited States amstercad
Notice the changes in this code for form.twig.
utility_classes
is nowform_utility_classes
. Howeverform_utility_classes
is used in four places, not three as in the GIT commit in question. With the code below, the website renders fine.That's all I have tested for. I didn't test the form component.
{% set form_utility_classes = form_utility_classes ? form_utility_classes : [] %} {% set classes = [ 'form', is_inline ? 'form-inline', ]|merge(form_utility_classes) %} <form{{ attributes.addClass(classes) }}> {{ children }} </form>
Thanks a lot for the discovery, do you mind to create a MR so I can check?
-
doxigo β
committed 08694dab on 6.0.x authored by
Amstercad β
Issue #3402732: A faulty commit breaks Radix
-
doxigo β
committed 08694dab on 6.0.x authored by
Amstercad β
- Status changed to Fixed
about 1 year ago 8:18am 22 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.