- Issue created by @fjgarlin
- @fjgarlin opened merge request.
- Status changed to Needs review
12 months ago 10:37pm 15 November 2023 - 🇪🇸Spain fjgarlin
The files reported here https://git.drupalcode.org/issue/drupal-3401971/-/jobs/341345 were the correct ones, even if the MR needs a rebase.
The fix I made was suggested here: https://stackoverflow.com/questions/68260856/gitlab-diff-between-merge-r...
- Status changed to RTBC
12 months ago 11:54pm 15 November 2023 - 🇺🇸United States smustgrave
This would be huge. Thanks for linking to the stackoverflow for reference.
- Status changed to Fixed
12 months ago 8:13am 16 November 2023 - 🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!
- Status changed to Needs work
12 months ago 11:07am 17 November 2023 - 🇪🇸Spain fjgarlin
I've been getting
fatal: bad object 7ddc1b8e0e312c46b62b8fecf49cf5795323052d
in certain jobs (ie: https://git.drupalcode.org/issue/drupal-3395977/-/jobs/353396).This seems to be due to the shallow clone depth, which is set to 20.
Reference: https://docs.gitlab.com/ee/ci/pipelines/settings.html#limit-the-number-o...We might need to set this variable to a bigger value. Investigating...
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
We might need to set this variable to a bigger value. Investigating...
Can we not simply override that only for the "test only" job? Since that's manually triggered anyway, the extra load would be minimal?
- @fjgarlin opened merge request.
- Status changed to Needs review
12 months ago 11:23am 17 November 2023 - 🇪🇸Spain fjgarlin
That's exactly what I did :-)
MR is ready for review: https://git.drupalcode.org/project/drupal/-/merge_requests/5451/diffs
The failing job where I discovered is no longer failing: https://git.drupalcode.org/issue/drupal-3395977/-/jobs/353569I went with 50 but happy for that to be changed to whatever makes the most sense.
- Status changed to Needs work
12 months ago 11:47am 17 November 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
12 months ago 11:49am 17 November 2023 - Status changed to RTBC
12 months ago 2:29pm 17 November 2023 - Status changed to Fixed
12 months ago 3:37pm 17 November 2023 - 🇬🇧United Kingdom catch
Committed/pushed the follow-up to 11.x and 10.2.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.