Remove unneeded static cache in file_save_upload()

Created on 14 November 2023, about 1 year ago
Updated 15 November 2023, about 1 year ago

Problem/Motivation

In πŸ“Œ Deprecate file_managed_file_save_upload(), file_save_upload() and _file_save_upload_from_form() and replace with a service Needs review we are modernising file uploads. The static $upload_cache; seems unnecessary, and it is worth checking this before refactoring the code.

The comments say:

" // Return cached objects without processing since the file will have
// already been processed and the paths in $_FILES will be invalid."

This issue is to evaluate whether this is still needed.

Steps to reproduce

Remove the cache and check if tests still pass.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Closed: won't fix

Version

11.0 πŸ”₯

Component
File moduleΒ  β†’

Last updated 9 days ago

Created by

πŸ‡¦πŸ‡ΊAustralia kim.pepper πŸ„β€β™‚οΈπŸ‡¦πŸ‡ΊSydney, Australia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @kim.pepper
  • @kimpepper opened merge request.
  • Status changed to Closed: won't fix about 1 year ago
  • πŸ‡¦πŸ‡ΊAustralia kim.pepper πŸ„β€β™‚οΈπŸ‡¦πŸ‡ΊSydney, Australia

    Looks like it is needed.

Production build 0.71.5 2024