Paragraphs (stable) title from form options not being applied.

Created on 14 November 2023, almost 2 years ago

Problem/Motivation

When trying to use the options in form display to set a custom title for the title and plural title fields, no changes are apparent.

Steps to reproduce

1. Go to form display.
2. Click on the options for a paragraph field using Paragraph (stable). Set a custom Paragraph Title and custom Paragraph Title Plural.
3. Try adding a block and no changes on the form will be apparent.

Proposed resolution

#value was taking the $label instead of $this->getSetting('title')

πŸ› Bug report
Status

Active

Version

1.15

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Meleagyr
  • Made some further improvements so that renaming the field is not needed at all.

  • πŸ‡ΊπŸ‡ΈUnited States msypes

    I've tested both patches and they both work. Nice job(s), thanks!
    Personally, I'm going with #2 at this time. I'm not seeing the advantage of #3, and that version seems to do a little too much. @Meleagyr, perhaps you could explain the use case for #3? Maybe I'm just missing something.

  • πŸ‡ΊπŸ‡ΈUnited States msypes

    Update:
    Actually, there is an issue when a field can take multiple paragraph types. Instead of displaying each paragraph type in the drop button, the displays the Title text for all, so there's no way to distinguish among them. See attached images.

  • First commit to issue fork.
  • Pipeline finished with Failed
    5 months ago
    Total: 432s
    #484088
  • πŸ‡§πŸ‡ͺBelgium tim-diels Belgium πŸ‡§πŸ‡ͺ

    Added both patches in 1 MR. The MR is the latest patch from #3
    Will test what msypes describes

  • Status changed to Needs review 5 months ago
  • πŸ‡§πŸ‡ͺBelgium tim-diels Belgium πŸ‡§πŸ‡ͺ

    Trying to reproduce the issue in the first place, but not able to do so. Is anyone else able to reproduce this?

  • πŸ‡«πŸ‡·France raphaeltbm

    Same problem here, the single title should only apply when you have only 1 possible paragraph for a field.
    I guess the problem is more complex when you have more paragraph possible, to be able to override them.

    If the current last patch is altered to apply only when there is only 1 paragraph type possible for the field, it would do for the current case (1 paragraph type selected for the current field) with the current settings available.

Production build 0.71.5 2024