exif_read_data() cannot use external URL

Created on 14 November 2023, 8 months ago

Problem/Motivation

Similar to #2478099: Unable to read EXIF data when uploading to S3 Bucket. β†’ , EXIF headers are read correctly for files stored locally. However, when the file is located externally (e.g., using the Flysystem β†’ module) and uploaded using a widget that doesn't validate on image resolution (e.g., using the DropzoneJS β†’ module) the headers cannot be read, even if a valid stream resource is available.

Proposed resolution

Since PHP 7.2 both local and stream resources are supported. Therefore, rewrite in _exif_orientation_rotate() the code that transforms a URI into a path or external URL.

Remaining tasks

  1. Review MR
πŸ› Bug report
Status

Needs review

Version

1.0

Component

Code

Created by

πŸ‡³πŸ‡±Netherlands Watergate

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Watergate
  • @watergate opened merge request.
  • Issue was unassigned.
  • Status changed to Needs review 8 months ago
  • πŸ‡³πŸ‡±Netherlands Watergate

    I've implemented the suggested change and opened a merge request.

    As stated in the issue description, the problem seems similar to #2478099: Unable to read EXIF data when uploading to S3 Bucket. β†’ . I've opened a new ticket since that ticket is about the Drupal 7 version of the module, and there seems to have already been some work/updates in the Drupal 8 (9/10) port/version.

Production build 0.69.0 2024