GitLab CI

Thanks. Both MRs looks good.
It would be great to have follow up tasks to fix phpcs, phpstan.

dww → closed merge request !31

Thanks! Definitely interested in moving this forward.

I closed the duplicate MR 31 targeting 8.x-1.x. We'll cherry-pick this to backport it, don't worry.

Pushed a commit to remove a bunch of noise from the default template so it's easier to see what's happening. Also broaden test coverage by opt'ing in to more test configurations by default. See https://git.drupalcode.org/project/address/-/pipelines/73207

If that's all green, I'll merge it.

dww → reopened merge request !31

Bummer, the JS tests are now failing on most (but not all) configurations with AJAX errors. Haven't debugged. Can't imagine anything in here is causing that. I'm not seeing problems locally. No more time right now, but if someone else wants to run with this, please do!

Just rebased both MR branches in case that helps. 😅

Maybe this is also caused by 📌 Stabilize FunctionalJavascript testing AJAX: add ::assertExpectedAjaxRequest() Fixed . Not sure.

I believe failed tests is not related to fail, I create separate issue 🐛 Fix functional javascript tests for Drupal 10.2 Active

Find way to fix tests. Let's merge this issue.

Yup, merged the FunctionalJavascript test fixes to both branches. This is ready. Merged and pushed to 2.0.x and 8.x-1.x (with the PREVIOUS_MAJOR testing enabled).

For now, I left drupalci.yml in the repo, so that if there are still issues with patches, those continue to be tested until the DA turns off DrupalCI entirely. I'd like @bojanz to approve before we remove that, so let's do it in another issue.

Thanks, y'all!
-Derek

dww → closed merge request !31

dww → closed merge request !32

so that if there are still issues with patches, those continue to be tested until the DA turns off DrupalCI entirely.

I think it's wise to do that as long as we can (also, I'm old fashioned and still like patches).

Thanks, everyone!

Yeah, I like patches, too. 😂

FYI: #3412417: Disable DrupalCI testing →

Automatically closed - issue fixed for 2 weeks with no activity.