Update existing 'tmgmt_job_item' entity while changing the ID is not supported.

After a brief investigation of the issue, I discovered that the problem stems from the "Delete duplicates" functionality within the doBatchSubmit method in the JobCheckoutManager class.

The issue arises because the JobCheckoutManager removes the job entity, and subsequently, the addTranslatedData method in the JobItem class attempts to update this entity in the database. However, the entity no longer exists in the database due to its removal by the JobCheckoutManager.

    // Delete duplicates.
    if ($existing_items_ids = $job->getConflictingItemIds()) {
      $item_storage = $this->entityTypeManager->getStorage('tmgmt_job_item');
      if (count($existing_items_ids) == $job->getItems()) {
        $this->messenger()->addStatus($this->t('All job items for job @label are conflicting, the job can not be submitted.', ['@label' => $job->label()]));
        return;
      }
      $item_storage->delete($item_storage->loadMultiple($existing_items_ids));
      $num_of_items = count($existing_items_ids);
      $this->messenger()->addWarning($this->getStringTranslation()->formatPlural($num_of_items, '1 conflicting item has been dropped for 
 job @label.', '@count conflicting items have been dropped for job @label.', ['@label' => $job->label()]));
    }

The solution to address the issue is to restrict the addTranslatedData from saving the entity if it doesn't exist.

The second improvement I made to the code is combining the getConflictingItemsMessage method in the JobForm message to make the message more clear and I'm considering the removal of this method due to the removal of duplicated jobitems before reaching it.

Hm, it's a bit unclear to me how this happens.

Could we add test coverage for this somehow, we have some tests about the duplicate removals, see \Drupal\Tests\tmgmt\Functional\TMGMTCartTest::testCartEnforceSourceLanguage and \Drupal\Tests\tmgmt_config\Functional\ConfigSourceListTest::testViewTranslation() for example.

I had this issue and the patch fixed it for me, thank you for contributing!

With much appreciation for the hard work on this issue, I can report that in my case there is still a loose end, as I am using tmgmt_openai to do automated translations and as a result, I have a huge number of jobs that are stuck at "in progress" but are not running ( 💬 Partially completed jobs items are not resumed/ completed on cron Active ).

After applying the patch, I requested new translations for a node that is marked as "in progress" but for which translations are not actually running because the process either timed out before, or aborted due to this issue here. After patching, the translation runs without errors this time. However, it never seems to drop the old jobs so after the translation finishes, the node is still not translated and the translation status is again stuck at "in progress".

It seems like I need to manually abort every single job that is stuck before being able to run it again, and if one of the languages fails, I need to abort again and lose the translations for the languages that were successful, until the whole operation succeeds. I understand I probably need to just do one language per node but that is going to take years :). As it is now, I am charged for multiple translations before I finally arrive at a fully translated node. I'm requesting 7 languages in one job and it's hit and miss.

Perhaps my case is not entirely within the scope of this issue, but at least in case where there are translation jobs stuck at "in progress", this patch will fix the error but as it seems, it won't allow new translations to be accepted because it does not drop the old jobs before running the newly requested one.

Hi alfthecat,
It might be late to answer your comment but tmgmt is designed intentionally not to override any translation requests that has those states unfournntally you need to abort them manually or using updb hook.

I get this same error:

Drupal\Core\Entity\EntityStorageException: Update existing 'tmgmt_job_item' entity while changing the ID is not supported. in Drupal\Core\Entity\ContentEntityStorageBase->doPreSave() (line 759 of /var/www/html/test_branch/web/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php).

What did I do wrong? How to avoid this?