PHP 8.2 TypeError: array_filter(): Argument #1 ($array) must be of type array, bool given in array_filter()

Still happening

TypeError: Drupal\markdown\PluginManager\InstallablePluginManager::sortDefinitions(): Argument #1 ($definitions) must be of type array, bool given, called in /web/modules/contrib/markdown/src/PluginManager/InstallablePluginManager.php on line 415 in Drupal\markdown\PluginManager\InstallablePluginManager->sortDefinitions() (line 688 of /srv/web/coreprovider.com.au/web/modules/contrib/markdown/src/PluginManager/InstallablePluginManager.php).

Installing the head branch seems to resolve the issue?

There are other issues with 8.2

Composer.json, set platform to 8.1

"config": {
        "platform": {
            "php": "8.1"
        },

The services don't match the interface definition.

fixing coding standard

@RohitRawat676 is it safe to remove isset?

- $label = isset($pluginDefinition['label']) ? $pluginDefinition['label'] : $plugin_id;
- $description = isset($pluginDefinition['description']) ? $pluginDefinition['description'] : '';
- $type = isset($pluginDefinition['type']) ? $pluginDefinition['type'] : 'other';
+ $label = $pluginDefinition['label'] ?? $plugin_id;
+ $description = $pluginDefinition['description'] ?? '';
+ $type = $pluginDefinition['type'] ?? 'other';

I see that the code has been condensed. I have had problems with white screen and this module.

I am all for fixing PHPCS issues, but there are a fair number of changes in patch #7 that are unrelated to the error stated in the issue summary. Please limit changes to those directly related to this issue. Even better, please submit it as a merge request!

chetan 11 → made their first commit to this issue’s fork.

Hi,
I have fixed the given error "TypeError: array_filter()". Please check the MR once.
Thanks.

@chetan11 Thank you for creating a merge request, however, the changes in the MR far exceed what is described in the issue description.

I have updated the condition for blank array & added Patch for solve the issue, please review.

Hello @markdorison, raised a new MR !28 to avoid confusion with #11 MR as I have a different take on the fix. Please review.

As raised in IS and in #2, #3, we are supposed to get an array (it can be an array with data or even an empty array for that matter) and but not bool value.

The fix shared in MR !28, ensures that we always return an array in src/PluginManager/InstallablePluginManager.php.

empty will work on both cases i.e., if static::$runtimeDefinitions[static::class] is NULL or [], as there is a possibility that getCachedDefinitions/getDefinitions may return NULL/[]

If there is no value, we make an early return with an empty array.

Also requesting the reporter @interlated to test the MR !28 and see if it resolves the reported errors.

Thanks!