- Issue created by @Martygraphie
- Merge request !49Issue #3401086: Standardize the labels of the theme's regions → (Merged) created by Martygraphie
- Status changed to Needs review
11 months ago 12:17pm 30 December 2023 - 🇫🇷France pdureau Paris
Good idea, but we can do better :)
There is a little lack of consistency in your proposition. For example:
header_operator_logo: Header - Operator Logo header_tools_links: Header - Tools links header_tools_search: Header - Tools search
"Operator Logo" is title case, but "Tools links" is sentence case.
I am proposing to use the sentence case in both sides of the dash:
Lorem ipsum dolor sit amet - Consectetur adipiscing elit
- Status changed to Needs work
11 months ago 12:21pm 2 January 2024 - Status changed to Needs review
10 months ago 4:42pm 11 January 2024 - 🇷🇪Réunion Martygraphie Saint-Denis (Réunion)
Hi Pierre,
Yes, good idea, I've updated my commit,
I'll let you check
Have a nice day - Assigned to pdureau
- Issue was unassigned.
- Status changed to Needs work
10 months ago 3:47pm 15 January 2024 - 🇫🇷France pdureau Paris
I can't merge your work because your branch is 9 commits behind 1.0.x. Can you rebase your branch and push again?
-
pdureau →
committed 583431f9 on 1.0.x authored by
Martygraphie →
Issue #3401086 by martygraphie: Standardize the labels of the theme's...
-
pdureau →
committed 583431f9 on 1.0.x authored by
Martygraphie →
- Status changed to Fixed
10 months ago 3:05pm 22 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.