- Issue created by @znerol
- Status changed to Needs review
about 1 year ago 2:36pm 10 November 2023 - Status changed to Active
about 1 year ago 3:27pm 10 November 2023 - 🇦🇺Australia dpi Perth, Australia
Hi @znerol when the code and MR is available let me know.
Idea sounds about right
- Merge request !11Issue #3400840 by dpi, znerol: Add synchronous transport → (Merged) created by znerol
- 🇨🇭Switzerland znerol
Done. Honestly, I just copied the
sm_test_transport
module.Note that there is no clear naming pattern in existing transports. The name of the doctrine transport module is
sm_transport_doctrine
. Maybe something to think about before merging. - Status changed to Needs review
about 1 year ago 3:52pm 12 November 2023 - Status changed to Needs work
about 1 year ago 11:05am 13 November 2023 - Status changed to Needs review
about 1 year ago 11:08am 13 November 2023 - 🇦🇺Australia dpi Perth, Australia
Note that there is no clear naming pattern in existing transports.
FYI the default doctrine transport is
doctrine
. I wouldn't be concerned about the test module transport naming schemes. As suggested in MR review, we'll keep it simple, we just need to figure the right term. Preferably not 'sync'. - Status changed to Needs work
about 1 year ago 3:37am 12 December 2023 - Status changed to Needs review
about 1 year ago 8:59am 12 December 2023 - 🇦🇺Australia dpi Perth, Australia
@znerol let me know if you have any opinions on the changes.
- Status changed to Fixed
about 1 year ago 9:12am 12 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.