Order comments are not sent/received by the api

Created on 10 November 2023, 7 months ago
Updated 14 November 2023, 7 months ago

Problem/Motivation

When creating a translation job, we can add a comment. Something must have changed in the API because the comments don't show up in the comments tab on Acclaro backoffice.

Steps to reproduce

Create a translation order and add a comment. Visit https://apisandbox.acclaro.com/ and open the newly created order.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇸🇮Slovenia Primsi

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Primsi
  • Status changed to Needs review 7 months ago
  • 🇸🇮Slovenia Primsi

    I just added an additional request to \Drupal\tmgmt_acclaro\Plugin\tmgmt\Translator\AcclaroTranslator::createOrder. Seems to work fine.

  • Status changed to Needs work 7 months ago
  • 🇨🇭Switzerland Berdir Switzerland
    +++ b/src/Plugin/tmgmt/Translator/AcclaroTranslator.php
    @@ -296,7 +296,16 @@ class AcclaroTranslator extends TranslatorPluginBase implements ContainerFactory
    +    // do a separate call for that.
    +    $this->doRequest($translator, 'AddOrderComment', [
    +      'orderid' => $order_result['orderid'],
    +      'comment' => $comment,
    +    ]);
    

    lets add a check for whether or not we actually have a comment and skip this call if not.

  • Status changed to Needs review 7 months ago
  • 🇸🇮Slovenia Primsi

    Added.

  • Status changed to Fixed 7 months ago
  • 🇨🇭Switzerland Berdir Switzerland

    Committed.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024