ExtraLinks should use route title, instead of hardcoded title

Thanks a lot Matt (@mglaman) for creating this issue and taking the time to look in module's current code, it's greatly appreciated! 🙏

If the initial requirement is to be able to alter the menu links added by the module, could you please try the approach suggested in the following issue?
#3488920-2: Change the deriver class of a menu link →

It would seem an implementation of hook_menu_links_discovered_alter could allow modifying any of the menu links added by the admin_toolbar_tools module.

But the solution suggested in the IS is also interesting though:

If we're calling \Drupal\admin_toolbar_tools\Plugin\Derivative\ExtraLinks::routeExists, actually return the route and use its title.

Sure why not, but

This might be difficult if it uses a title callback, though.

got me a bit worried... probably some more work here 😅

I would greatly appreciate your opinion on this feature and feedback on the solution suggested above, in particular, whether it would really be worth spending more time on fixing this issue in the admin_toolbar_tools module.

For the time being, closing this issue as Won't fix, since it seems there is already a proper solution provided by Drupal Core.
Feel free to re-open the issue at any time if you consider these changes would still be needed, we would be glad to take another look.

Thanks in advance! 🙂