D9-D10 upgrade causes fatal error in RulesLog.php

Unlikely you're using the latest version of Rules. That was changed over a year ago in #3288059: [D10] Update code that implements \Psr\Log\LoggerInterface due to Psr/Log version 3 →

chetan 11 → made their first commit to this issue’s fork.

Requested information has not been provided

Allow me to re-open the issue. I have the exact same error.
Updated to most recent version of Rules: "drupal/rules": "^3.0@alpha", as part of upgrade of Drupal 9.5.2 to Drupal 10.2..6

The change cited in #2 was made in accordance with the Drupal core change record: https://www.drupal.org/node/3284415 →

If there has been a subsequent change in Drupal core that supercedes this then please cite that change.

I cannot cite anything. I'm just reporting, I have the exact same error message, and a search led me to this issue.

I'll be happy to provide any info needed to investigate. To start with, here's the content of composer.json:

{
"name": "drupal/legacy-project",
"description": "Project template for Drupal 9 projects with composer following drupal/drupal layout",
"type": "project",
"license": "GPL-2.0-or-later",
"homepage": " https://www.drupal.org/project/drupal → ",
"support": {
"docs": " https://www.drupal.org/docs/user_guide/en/index.html → ",
"chat": " https://www.drupal.org/node/314178 → "
},
"repositories": [
{
"type": "composer",
"url": "https://packages.drupal.org/8"
}
],
"require": {
"composer/installers": "^1.9",
"cweagans/composer-patches": "^1.7",
"drupal/admin_toolbar": "^3.1",
"drupal/animated_gif": "^2.0",
"drupal/backup_migrate": "^5.0",
"drupal/block_class": "^2.0@beta",
"drupal/bootstrap": "^3.24",
"drupal/bootstrap_barrio": "^5.5",
"drupal/color": "^1.0",
"drupal/composer_deploy": "^1.7",
"drupal/context": "^5.0@RC",
"drupal/core-composer-scaffold": "^10",
"drupal/core-project-message": "^10",
"drupal/core-recommended": "^10",
"drupal/devel": "^5.0",
"drupal/easy_breadcrumb": "^2.0",
"drupal/embed_view_block": "^1.0@beta",
"drupal/entity_reference_revisions": "^1.9",
"drupal/gin": "^3.0@beta",
"drupal/gin_lb": "^1.0@RC",
"drupal/gin_login": "^1.2",
"drupal/gin_toolbar": "^1.0@beta",
"drupal/honeypot": "^2.0",
"drupal/iframe": "^2.18",
"drupal/inline_responsive_images": "^3.0@beta",
"drupal/lang_dropdown": "^2.1",
"drupal/layout_builder_admin_theme": "^2.0",
"drupal/layout_builder_at": "^2.13",
"drupal/layout_builder_modal": "^1.1",
"drupal/layout_builder_styles": "^2.0",
"drupal/layout_disable": "^2.0",
"drupal/linkit": "^6.1",
"drupal/maillog": "^1.0",
"drupal/mailsystem": "^4.3",
"drupal/media_library_theme_reset": "^1.1",
"drupal/media_responsive_thumbnail": "^1.2",
"drupal/metatag": "^1.19",
"drupal/mimemail": "^1.0@alpha",
"drupal/paragraphs": "^1.13",
"drupal/path_redirect_import": "^2.0",
"drupal/pathauto": "^1.9",
"drupal/plausible": "^2.0@beta",
"drupal/quick_node_clone": "^1.18",
"drupal/redirect": "^1.8",
"drupal/rules": "^3.0@alpha",
"drupal/search_api": "^1.23",
"drupal/simplenews": "^4.0",
"drupal/smtp": "^1.2",
"drupal/symfony_mailer": "^1.1@beta",
"drupal/term_condition": "^2.0",
"drupal/theme_switcher": "^2.0",
"drupal/token": "^1.10",
"drupal/upgrade_status": "^4.3",
"drupal/views_data_export": "^1.2",
"drupal/views_taxonomy_term_name_into_id": "^1.0@RC",
"drupal/views_term_hierarchy_weight_field": "^1.1",
"drupal/viewsreference": "^2.0@beta",
"drupal/webform": "^6.2@beta",
"drupal/weight": "^3.4",
"drush/drush": "^12.5",
"wikimedia/composer-merge-plugin": "^2.0"
},
"conflict": {
"drupal/drupal": "*"
},
"minimum-stability": "dev",
"prefer-stable": true,
"config": {
"sort-packages": true,
"allow-plugins": {
"composer/installers": true,
"drupal/core-composer-scaffold": true,
"drupal/core-project-message": true,
"phpstan/extension-installer": true,
"dealerdirect/phpcodesniffer-composer-installer": true,
"wikimedia/composer-merge-plugin": true,
"cweagans/composer-patches": true
}
},
"extra": {
"enable-patching": true,
"patches": {
"drupal/core": {
" https://www.drupal.org/project/drupal/issues/2816447#comment-14615388 🐛 Get feed title in correct language Needs work ": " https://www.drupal.org/files/issues/2022-07-19/2816447-49.patch → "
}
}
},
"extra": {
"merge-plugin": {
"include": [
"modules/contrib/webform/composer.libraries.json"
]
},
"drupal-scaffold": {
"locations": {
"web-root": "web/"
}
},
"installer-paths": {
"web/core": [
"type:drupal-core"
],
"web/libraries/{$name}": [
"type:drupal-library"
],
"web/modules/contrib/{$name}": [
"type:drupal-module"
],
"web/profiles/contrib/{$name}": [
"type:drupal-profile"
],
"web/themes/contrib/{$name}": [
"type:drupal-theme"
],
"web/drush/Commands/contrib/{$name}": [
"type:drupal-drush"
],
"web/modules/custom/{$name}": [
"type:drupal-custom-module"
],
"web/profiles/custom/{$name}": [
"type:drupal-custom-profile"
],
"web/themes/custom/{$name}": [
"type:drupal-custom-theme"
]
}
}
}

To the maintainer
Not sure what you will have me do here. I'm more than happy to provide any info, you need.

According to #2 / Core change, I have tried to follow the recommendations, thus tried both suggestions. Both create an additional error.

So, as an example, replacing line 52 in /modules/rules/src/Logger/RulesLog.php with
public function log($level, string|\Stringable $message, array $context = []): void {
or
public function log($level, $message, array $context = []): void {

produces the following error:
TypeError: Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher::dispatch(): Argument #1 ($event) must be of type object, string given, called in /var/www/html/web/modules/contrib/rules/src/Logger/RulesLog.php on line 75 in Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch() (line 89 of /var/www/html/web/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php).

I'm closing this one and have created https://www.drupal.org/project/rules/issues/3447241 🐛 D9-D10 upgrade causes fatal error in RulesLog.php Active

My questions are important because any change made to the method signature has to be done in a backwards-compatible manner so that it does not break existing sites that use Rules.

Thus, it is critical for me to know when and where this method signature was changed, so I can modify the dependencies appropriately.

The change was probably made in Symfony, and Drupal probably changed the minimum version of Symfony required for core Drupal, triggering the error. But which version of core Drupal?

I will eventually research this and figure it out on my own, but if you would like something done sooner please do that work yourself and provide me with the information I requested.

Hi TR,

If I could fix this myself, I would. What information are you requesting?

Declaration of Drupal\rules\Logger\RulesLog::log($level, $message, array $context = []) must be compatible with Drupal\Core\Logger\RfcLoggerTrait::log($level, Stringable|string $message, array $context = []): void

Once again, back to what I said in #2:

Unlikely you're using the latest version of Rules. That was fixed over a year ago in #3288059: [D10] Update code that implements \Psr\Log\LoggerInterface due to Psr/Log version 3 → within a few days after Drupal core changed the interface.

I can say this with confidence because ever since 6/18/22 that method has had the following signature: RulesLog::log($level, $message, array $context = []): void. Notice the void return type, whereas your error message does NOT show that void return type. That means you're using an old version of Rules.

The current signature agrees with the core signature, and none of the extensive Rules test cases generate an error. Strict type checking in tests was turned on back in July in 📌 Add declare(strict_types=1) to all tests Fixed and this didn't reveal anything related to this issue.

So I'm closing this as "cannot reproduce".