Contrib.social

keysave.module has a typo in the condition and the redundant code

Open on Drupal.org →
Created on 9 November 2023, almost 2 years ago
Updated 18 November 2023, almost 2 years ago

Problem/Motivation

It's not possible to include forms by "base_form_id" due to the wrong condition (from lines 57 to 60) in the keysave.module. One version of the correct condition:

if (!$callback_base) {
  // Remaining check requires a value for $callback_base.
  return;
}

But in spite of the wrong condition, the module work as expected. This happens because all the code from lines 52 to 68 is redundant. As the forms with base_form_ids "field_config_form" and "entity_form_display_form" is subclasses of the "EntityForm" class, then the library has already been added to them in the previous code.

Proposed resolution

Remove the redundant code from lines 52 to 68.

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

wombatbuddy

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024