Deprecated: Creation of dynamic property Drupal\course\Storage\CourseObjectFulfillmentStorage::$entityClass is deprecated in /web/modules/contrib/course/src/Storage/CourseObjectFulfillmentStorage.php on line 40

Created on 8 November 2023, about 1 year ago
Updated 15 November 2023, about 1 year ago

Followup to #3256467: Setting the entityClass property directly is deprecated in drupal:9.3.0 and has no effect in drupal:10.0.0. β†’

We did that for objects (because they are bundled entities) but fulfillment are not there yet. Fulfillments don't have bundle storage yet so this might be a hack until then.

πŸ› Bug report
Status

Needs review

Version

3.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States djdevin Philadelphia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @djdevin
  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 year ago
    37 pass
  • πŸ‡ΊπŸ‡ΈUnited States djdevin Philadelphia
  • Thanks @djdevin! The patch fixes an issue when progressing through Book and Quiz objects in a Drupal 10 course outline.

    However, there are now some errors when editing a course outline:

    1. After adding an object to the outline, a Drupal.AjaxError occurs. Reloading the page then shows the added object.
    2. When deleting an object from the outline and then clicking 'Save outline', an exception is thrown:
      Call to a member function get() on null
      /src/Storage/CourseObjectFulfillmentStorage.php on line 106
      $ret = $available[$co->get('object_type')->getString()] ?? [];

      ** Note: I was running into this every time an object was deleted from the outline, but now I can't replicate (?).

Production build 0.71.5 2024